Skip to content

reconstruct orderId and validate for cowswap#144

Open
to-sh-1 wants to merge 3 commits into
developfrom
validatePreSign
Open

reconstruct orderId and validate for cowswap#144
to-sh-1 wants to merge 3 commits into
developfrom
validatePreSign

Conversation

@to-sh-1

@to-sh-1 to-sh-1 commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

@to-sh-1 to-sh-1 changed the title reconstruct orderId and validated for cowswap reconstruct orderId and validate for cowswap Aug 2, 2022

@0xean 0xean left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is a little hard for me to review with so little understanding of cowswap.

Have you been able to test that it works end to end for a trade (not just the pre-signature)?

@to-sh-1

to-sh-1 commented Aug 8, 2022

Copy link
Copy Markdown
Contributor Author

This one is a little hard for me to review with so little understanding of cowswap.

Have you been able to test that it works end to end for a trade (not just the pre-signature)?

Yes, I was successfully able to do a trade on forked mainnet. This one does get hairy as I'm not an assembly expert, but I've spent some time looking at the code and seeing what it does and it's basically just taking info from the quote data from cowswap and creating the orderId from that data and matching with the orderId we are presigning. If you check the reference the guy who made the issue had an example and it's mostly copied from that. We can get on a call and walk through it if you would like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants